Skip to content

Removing SimpleMock test from pandas.util.testing #21482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2018
Merged

Removing SimpleMock test from pandas.util.testing #21482

merged 3 commits into from
Jun 15, 2018

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 14, 2018 •
edited
Loading

Removing SimpleMock test

@uds5501
Update testing.py
d66fab5 
Removing SimpleMock test
@jschendel jschendel added Testing pandas testing functions or related to the test suite Clean labels Jun 14, 2018
@jschendel jschendel added this to the 0.24.0 milestone Jun 14, 2018
@TomAugspurger
Copy link
Contributor

restarted the HTTP failure.

TomAugspurger
TomAugspurger reviewed Jun 14, 2018
View reviewed changes
pandas/util/testing.py
@@ -2263,37 +2263,6 @@ def wrapper(*args, **kwargs):
with_connectivity_check = network


class SimpleMock(object):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like SimpleMock is used in stdin_encoding below. Can you see if stdin_encoding is used anywhere, and maybe remove it too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomAugspurger Sure, will do

@uds5501
Update testing.py
64418b0 
removed `stdin_encoding`
@codecov
Copy link

codecov bot commented Jun 14, 2018 •
edited
Loading

Codecov Report

Merging #21482 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21482      +/-   ##
==========================================
+ Coverage   91.89%   91.92%   +0.02%     
==========================================
  Files         153      153              
  Lines       49604    49585      -19     
==========================================
- Hits        45584    45581       -3     
+ Misses       4020     4004      -16
Flag Coverage Δ
#multiple 90.32% <ø> (+0.02%) ⬆️
#single 41.89% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 85.96% <ø> (+1.35%) ⬆️
pandas/core/indexes/base.py 96.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf1c3dc...edb4959. Read the comment docs.

@uds5501
Copy link
Contributor Author

uds5501 commented Jun 15, 2018

@TomAugspurger any suggestions on how this could pass travis?

@jreback
Copy link
Contributor

jreback commented Jun 15, 2018

pandas/util/testing.py:2265:1: E302 expected 2 blank lines, found 1

lint issue

@jreback
Copy link
Contributor

jreback commented Jun 15, 2018

lgtm. ping on green.

@uds5501
Copy link
Contributor Author

uds5501 commented Jun 15, 2018

@jreback . build and tests passed.

@jreback jreback merged commit 6c71c45 into pandas-dev:master Jun 15, 2018
@jreback
Copy link
Contributor

jreback commented Jun 15, 2018

thanks @uds5501

david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
@uds5501 @david-liu-brattle-1
Removing SimpleMock test from pandas.util.testing (pandas-dev#21482)
077566e
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@uds5501
Removing SimpleMock test from pandas.util.testing (pandas-dev#21482)
ffa4e03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

CLN: remove SimpleMock from pandas.util.testing
4 participants
@uds5501 @TomAugspurger @jreback @jschendel