Skip to content

Adding Multiindex support to dataframe pivot function(Fixes #21425) #21467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/source/whatsnew/v0.24.0.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ Other Enhancements
- :func:`Series.mode` and :func:`DataFrame.mode` now support the ``dropna`` parameter which can be used to specify whether NaN/NaT values should be considered (:issue:`17534`)
- :func:`to_csv` now supports ``compression`` keyword when a file handle is passed. (:issue:`21227`)
- :meth:`Index.droplevel` is now implemented also for flat indexes, for compatibility with MultiIndex (:issue:`21115`)
- :func:'Dataframe.pivot' now supports multiple columns as index. (:issue:'21425')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'columns as an index'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I will make those changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected




.. _whatsnew_0240.api_breaking:
Expand Down
11 changes: 10 additions & 1 deletion pandas/core/reshape/reshape.py
Original file line number Diff line number Diff line change
Expand Up @@ -392,12 +392,21 @@ def pivot(self, index=None, columns=None, values=None):
cols = [columns] if index is None else [index, columns]
append = index is None
indexed = self.set_index(cols, append=append)

else:
if index is None:
index = self.index
index = MultiIndex.from_arrays([index, self[columns]])
# added this case to handle multi-index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make a comment that reflects what is here (not added)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

elif isinstance(index, list):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use is_list_like instead here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I will do it.

indexes = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this a list-comprehension

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

for i in index:
indexes.append(self[i])
indexes.append(self[columns])
index = MultiIndex.from_arrays(indexes)
else:
index = self[index]
index = MultiIndex.from_arrays([index, self[columns]])
index = MultiIndex.from_arrays([index, self[columns]])

if is_list_like(values) and not isinstance(values, tuple):
# Exclude tuple because it is seen as a single column name
Expand Down
17 changes: 17 additions & 0 deletions pandas/tests/reshape/test_pivot.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,23 @@ def test_pivot_multi_functions(self):
expected = concat([means, stds], keys=['mean', 'std'], axis=1)
tm.assert_frame_equal(result, expected)

def test_pivot_multiple_columns_as_index(self):
# adding the test case for multiple columns as index (#21425)
df = DataFrame({'lev1': [1, 1, 1, 1, 2, 2, 2, 2],
'lev2': [1, 1, 2, 2, 1, 1, 2, 2],
'lev3': [1, 2, 1, 2, 1, 2, 1, 2],
'values': [0, 1, 2, 3, 4, 5, 6, 7]})
result = df.pivot(index=['lev1', 'lev2'],
columns='lev3',
values='values')
exp_index = pd.MultiIndex.from_product([[1, 2], [1, 2]],
names=['lev1', 'lev2'])
exp_columns = Index([1, 2], name='lev3')
expected = DataFrame([[0, 1], [2, 3], [4, 5], [6, 7]],
exp_index,
exp_columns)
tm.assert_frame_equal(result, expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example where the values argument is not mentioned? eg df.pivot(index=['lev1', 'lev2'], columns='lev3')
(I think this will not yet work, but should work)


def test_pivot_index_with_nan(self):
# GH 3588
nan = np.nan
Expand Down