BUG: fix get_indexer_non_unique with CategoricalIndex key #21457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toobaz
added
Indexing
jreback
approved these changes
Jun 13, 2018
pandas/core/indexes/category.py
Outdated
| @@ -598,7 +598,11 @@ def get_indexer_non_unique(self, target): | |||
| target = ibase._ensure_index(target) | |||
|
|
|||
| if isinstance(target, CategoricalIndex): | |||
| target = target.categories | |||
| if target.categories is self.categories: | |||
There was a problem hiding this comment.
can you add a comment here about what you are doing (e.g. why this conditional)
toobaz
force-pushed
the
non_unique_categorical_21448
branch
from
d5aee5c to
2296f17
Compare
Codecov Report
@@ Coverage Diff @@
## master #21457 +/- ##
==========================================
+ Coverage 91.89% 91.9% +<.01%
==========================================
Files 153 153
Lines 49600 49606 +6
==========================================
+ Hits 45580 45589 +9
+ Misses 4020 4017 -3
Continue to review full report at Codecov.
|
toobaz
force-pushed
the
non_unique_categorical_21448
branch
from
2296f17 to
85f0c70
Compare
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
jorisvandenbossche
pushed a commit
that referenced
this pull request
Jun 29, 2018
jorisvandenbossche
pushed a commit
that referenced
this pull request
Jul 2, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff