Skip to content

Fix tests fragile to PATH #21453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2018
Merged

Fix tests fragile to PATH #21453

merged 1 commit into from
Jun 13, 2018

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Jun 12, 2018 •
edited by TomAugspurger
Loading

Closes #21450

Get path of current python interpreter running opposed to one on users path.

WillAyd
WillAyd approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Only downside I can think of with this is when sys.executable returns an empty string, though I couldn't find definitive documentation on when that happens (embedded applications?) so maybe not an issue

cc @TomAugspurger

@codecov
Copy link

codecov bot commented Jun 13, 2018 •
edited
Loading

Codecov Report

Merging #21453 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21453      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files         153      153              
  Lines       49600    49600              
==========================================
- Hits        45580    45578       -2     
- Misses       4020     4022       +2
Flag Coverage Δ
#multiple 90.29% <ø> (-0.01%) ⬇️
#single 41.86% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 84.6% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab668b0...e846c18. Read the comment docs.

@gfyoung gfyoung added CI Continuous Integration Unreliable Test Unit tests that occasionally fail labels Jun 13, 2018
@jreback jreback added this to the 0.23.2 milestone Jun 13, 2018
@jreback jreback merged commit 7a49449 into pandas-dev:master Jun 13, 2018
@jreback
Copy link
Contributor

jreback commented Jun 13, 2018

thanks @WillAyd

david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
@alimcmaster1 @david-liu-brattle-1
Fix tests fragile to PATH (pandas-dev#21453)
ce68870
jorisvandenbossche pushed a commit that referenced this pull request Jun 29, 2018
@alimcmaster1 @jorisvandenbossche
Fix tests fragile to PATH (#21453)
040bbc6 
(cherry picked from commit 7a49449)
jorisvandenbossche pushed a commit that referenced this pull request Jul 2, 2018
@alimcmaster1 @jorisvandenbossche
Fix tests fragile to PATH (#21453)
475c8bc 
(cherry picked from commit 7a49449)
@alimcmaster1 alimcmaster1 deleted the fragile-tests branch August 11, 2018 18:10
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@alimcmaster1
Fix tests fragile to PATH (pandas-dev#21453)
6051999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Unreliable Test Unit tests that occasionally fail
Projects
None yet
Milestone
0.23.2
Development

Successfully merging this pull request may close these issues.
5 participants
@alimcmaster1 @jreback @WillAyd @jorisvandenbossche @gfyoung