-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Resolves Issue 21344: provide a timedelta in a non-string format #21444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -795,7 +795,11 @@ cdef class _Timedelta(timedelta): | |
|
||
@property | ||
def resolution(self): | ||
""" return a string representing the lowest resolution that we have """ | ||
""" | ||
Return a string representing the lowest resolution that we have. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of |
||
Note that this is nonstandard behavior. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead, could you create a "See Also" section with the new method name, similar to this: https://pandas.pydata.org/pandas-docs/stable/generated/pandas.Series.isin.html |
||
To retrieve a timedelta object use the resolution_timedelta property | ||
""" | ||
|
||
self._ensure_components() | ||
if self._ns: | ||
|
@@ -813,6 +817,32 @@ cdef class _Timedelta(timedelta): | |
else: | ||
return "D" | ||
|
||
@property | ||
def resolution_timedelta(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The general idea was to have this new property return |
||
""" | ||
Return a timedelta object (rather than a string) | ||
representing the lowest resolution we have. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of |
||
to retrieve a string use the resolution property. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead, could you create a "See Also" section with the new method name, similar to this: https://pandas.pydata.org/pandas-docs/stable/generated/pandas.Series.isin.html |
||
""" | ||
|
||
self._ensure_components() | ||
if self._ns: | ||
# At time of writing datetime.timedelta doesn't | ||
# support nanoseconds as a keyword argument. | ||
return timedelta(microseconds=0.1) | ||
elif self._us: | ||
return timedelta(microseconds=1) | ||
elif self._ms: | ||
return timedelta(milliseconds=1) | ||
elif self._s: | ||
return timedelta(seconds=1) | ||
elif self._m: | ||
return timedelta(minutes=1) | ||
elif self._h: | ||
return timedelta(hours=1) | ||
else: | ||
return timedelta(days=1) | ||
|
||
@property | ||
def nanoseconds(self): | ||
""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move to
v0.23.2.txt