parametrize tests, unify repeated tests #21405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #21405 +/- ##
==========================================
+ Coverage 91.89% 91.9% +<.01%
==========================================
Files 153 153
Lines 49600 49600
==========================================
+ Hits 45580 45583 +3
+ Misses 4020 4017 -3
Continue to review full report at Codecov.
|
jreback
requested changes
Jun 12, 2018
| @@ -148,6 +148,50 @@ def test_apply_out_of_range(self, tz): | |||
| # so ignore | |||
| pass | |||
|
|
|||
| def test_offsets_compare_equal(self): | |||
| # root cause of GH#456 | |||
There was a problem hiding this comment.
can you add a more informative comment
|
|
||
| def test_rsub(self): | ||
| if self._offset is None or not hasattr(self, 'd'): | ||
| # TODO: define `d` for classes where it is missing? |
There was a problem hiding this comment.
can you expand this coment (and similar fo radd)
There was a problem hiding this comment.
Sure. Turns out its easy just to define d for all but one of the subclasses that is currently missing it.
| @@ -1424,33 +1429,18 @@ def testEQ(self): | |||
| assert (CustomBusinessHour(holidays=['2014-06-27']) != | |||
| CustomBusinessHour(holidays=['2014-06-28'])) | |||
|
|
|||
| def test_sub(self): | |||
| # override Base implementation | |||
There was a problem hiding this comment.
can you provide a better comment here. why is skipped?
jreback
approved these changes
Jun 13, 2018
|
thanks @jbrockmendel |
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's more to do, but the diff is already pretty big as it is.
There are a handful of test methods that are defined in 5-6 test classes. By moving those to the base class we a) get rid of duplicate code and b) run the tests for all (well, most)
DateOffsetsubclasses.