Skip to content

DOC: isin() docstring change DataFrame to pd.DataFrame #21403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

beepscore
Copy link
Contributor

@beepscore beepscore commented Jun 9, 2018

isin() docstring change DataFrame to pd.DataFrame

@pep8speaks
Copy link

pep8speaks commented Jun 9, 2018

Hello @beepscore! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on June 13, 2018 at 12:10 Hours UTC

@WillAyd
Copy link
Member

WillAyd commented Jun 9, 2018

Simple enough. If you can correct the LINT issue then lgtm

@gfyoung gfyoung added the Docs label Jun 9, 2018
@jreback jreback added this to the 0.24.0 milestone Jun 13, 2018
@jorisvandenbossche jorisvandenbossche changed the title isin() docstring change DataFrame to pd.DataFrame DOC: isin() docstring change DataFrame to pd.DataFrame Jun 13, 2018
@codecov
Copy link

codecov bot commented Jun 13, 2018

Codecov Report

Merging #21403 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21403   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49596    49596           
=======================================
  Hits        45576    45576           
  Misses       4020     4020
Flag Coverage Δ
#multiple 90.29% <ø> (ø) ⬆️
#single 41.86% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 97.22% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415012f...ee2c818. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit b3744a1 into pandas-dev:master Jun 13, 2018
@jorisvandenbossche
Copy link
Member

@beepscore Thanks!
(I just changed foo to df2, many people are not familiar with 'foo', bar', ..)

david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants