BUG to_clipboard passes the wrong sep to to_csv #21398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, the sep is \t as to_csv expects. A commit changes the sep to r'\t', causing an exception. The exception is suppressed (with except: pass), causing the data frame to be passed to to_string downstream (even though it should be handled to to_csv)
gfyoung
added
the
Regression
|
@anhqle : Thanks for this! Going to need a test to protect against this in the future. |
Codecov Report
@@ Coverage Diff @@
## master #21398 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 153 153
Lines 49596 49596
=======================================
Hits 45576 45576
Misses 4020 4020
Continue to review full report at Codecov.
|
|
Close because duplicate of #21111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the sep is
\tas to_csv expects. A commit changes the sep tor'\t',causing an exception (becausecsv.writerexpects the delimiter to be a one-character string). The exception is suppressed (withpassin theexceptblock), causing the data frame to be passed toto_stringdownstream (even though it should be handled byto_csv)Changing
r't'back to\tis a quick fix, but justpassin theexceptblock seems like the more problematic root cause (that I'm not handling here).git diff upstream/master -u -- "*.py" | flake8 --diff