Skip to content

TST: adding test cases for verifying correct values shown by pivot_table() #21378 #21393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 15, 2018
Merged

TST: adding test cases for verifying correct values shown by pivot_table() #21378 #21393

merged 6 commits into from
Jun 15, 2018

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 8, 2018 •
edited
Loading

BUG: Incorrect values shown by pivot_table() #21378

Just added a new test to verify the included patch in master branch

@uds5501
Update test_pivot.py
27852bc 
BUG: Incorrect values shown by pivot_table() pandas-dev#21378
@uds5501 uds5501 changed the title Update test_pivot.py BUG: Incorrect values shown by pivot_table() #21378 Jun 8, 2018
@uds5501 uds5501 changed the title BUG: Incorrect values shown by pivot_table() #21378 TST: adding test cases for verifying correct values shown by pivot_table() #21378 Jun 8, 2018
@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Groupby Categorical Categorical Data Type labels Jun 8, 2018
gfyoung
gfyoung approved these changes Jun 8, 2018
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uds5501 : This is awesome. Thanks!

@codecov
Copy link

codecov bot commented Jun 9, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6c71c45). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #21393   +/-   ##
=========================================
  Coverage          ?   91.89%           
=========================================
  Files             ?      153           
  Lines             ?    49604           
  Branches          ?        0           
=========================================
  Hits              ?    45586           
  Misses            ?     4018           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.3% <ø> (?)
#single 41.88% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c71c45...355aea3. Read the comment docs.

@uds5501
Copy link
Contributor Author

uds5501 commented Jun 9, 2018

@gfyoung thanks! you may now close the issue after the merge 👍

@jreback jreback added this to the 0.23.2 milestone Jun 13, 2018
jreback
jreback requested changes Jun 13, 2018
View reviewed changes
pandas/tests/reshape/test_pivot.py Outdated
@@ -142,6 +142,25 @@ def test_pivot_table_dropna_categoricals(self, dropna):

tm.assert_frame_equal(result, expected)

def test_pivot_with_new_patch(self, dropna):
# gh-21133
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just add this example into an existing test (the one below looks like a candidate).

@uds5501
Update test_pivot.py
4bab2bd 
Added a new example in pre-existing test
@pep8speaks
Copy link

pep8speaks commented Jun 13, 2018 •
edited
Loading

Hello @uds5501! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on June 15, 2018 at 17:32 Hours UTC

@uds5501
Copy link
Contributor Author

uds5501 commented Jun 13, 2018

@jreback Done the changes. Any other improvement you'd like?

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.23.2, 0.24.0 Jun 14, 2018
@uds5501
Copy link
Contributor Author

uds5501 commented Jun 15, 2018

@jreback fixed the errors in the test. Any other improvement required?

@jreback jreback mentioned this pull request Jun 15, 2018
Closed
4 tasks
@jreback jreback merged commit 9e982e1 into pandas-dev:master Jun 15, 2018
@jreback
Copy link
Contributor

jreback commented Jun 15, 2018

thanks @uds5501

david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
@uds5501 @david-liu-brattle-1
TST: adding test cases for verifying correct values shown by pivot_ta…
b9650a1 
…ble() pandas-dev#21378 (pandas-dev#21393)
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@uds5501
TST: adding test cases for verifying correct values shown by pivot_ta…
8967d3a 
…ble() pandas-dev#21378 (pandas-dev#21393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

BUG: Incorrect values shown by pivot_table()
5 participants
@uds5501 @pep8speaks @jreback @gfyoung @jorisvandenbossche