Skip to content

DOC: update multi-index term with MultiIndex #21382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2018

Conversation

FabioRosado
Copy link
Contributor

@FabioRosado FabioRosado commented Jun 8, 2018

Hello,
before I start working on part 2 of the sphinx spelling extension I wanted to submit this PR in order to fix the double use of multi-index and MultiIndex. I have changed all multi-index mentions through the documentation to MultiIndex, this meant that some titles needed changing and new linking needed to be done. I have tested the documentation locally and everything seems to be working okay.

I have also reverted the changes to some adverbs that got changed previously (which shouldn't have according to @h-vetinari)

I hope that creating this PR before working on part 2 is okay. If you would rather me add this and the next one together let me know and I'll update the title and whatnot 😄 👍

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - independent PRs are always better than coupling

@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #21382 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21382      +/-   ##
==========================================
+ Coverage   91.85%   91.88%   +0.03%     
==========================================
  Files         153      153              
  Lines       49570    49570              
==========================================
+ Hits        45533    45549      +16     
+ Misses       4037     4021      -16
Flag Coverage Δ
#multiple 90.28% <ø> (+0.03%) ⬆️
#single 41.86% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_core.py 83.53% <0%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfac97...767485d. Read the comment docs.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me as well

@gfyoung gfyoung merged commit 05e55aa into pandas-dev:master Jun 8, 2018
@gfyoung
Copy link
Member

gfyoung commented Jun 8, 2018

@FabioRosado : Thanks!

@FabioRosado FabioRosado deleted the spelling branch June 8, 2018 19:28
david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
* Change multi-index to MultiIndex

* Revert changes to adverbs, add words to wordlist
@jorisvandenbossche jorisvandenbossche added this to the 0.24.0 milestone Jun 29, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
* Change multi-index to MultiIndex

* Revert changes to adverbs, add words to wordlist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants