Skip to content

MAINT: More friendly error msg on Index overflow #21377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2018
Merged

MAINT: More friendly error msg on Index overflow #21377

merged 2 commits into from
Jun 12, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jun 8, 2018

Display a more friendly error message when there is an OverflowError during Index construction.

Partially addresses #15832.

@gfyoung gfyoung added Indexing Related to indexing on series/frames, not to indexes themselves Dtype Conversions Unexpected or buggy dtype conversions Error Reporting Incorrect or improved errors from pandas labels Jun 8, 2018
@gfyoung gfyoung added this to the 0.23.2 milestone Jun 8, 2018
@gfyoung
Copy link
Member Author

gfyoung commented Jun 8, 2018

Marked this for 0.23.2 since this is relatively minor and is in no rush to be squeezed into 0.23.1. That being said, if someone wants to push for tomorrow's release, be my guest. 😄

@codecov
Copy link

codecov bot commented Jun 8, 2018 •
edited
Loading

Codecov Report

Merging #21377 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21377      +/-   ##
==========================================
+ Coverage   91.89%   91.89%   +<.01%     
==========================================
  Files         153      153              
  Lines       49596    49599       +3     
==========================================
+ Hits        45576    45579       +3     
  Misses       4020     4020
Flag Coverage Δ
#multiple 90.29% <100%> (ø) ⬆️
#single 41.86% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.61% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4807905...44e95e6. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jun 8, 2018

ok seems reasonable.

@gfyoung
Copy link
Member Author

gfyoung commented Jun 8, 2018

ok seems reasonable.

Cool. lmk if there are any changes that need to be made to make this merge-able.

@gfyoung
Copy link
Member Author

gfyoung commented Jun 10, 2018

@jreback : friendly ping

gfyoung added 2 commits June 11, 2018 14:06
@gfyoung
MAINT: More useful error msg on Index overflow
12016fe 
Display a more friendly error message when there
is an OverflowError during Index construction.

Partially addresses pandas-devgh-15832.
@gfyoung
DOC: Clarify how Index.__new__ handles dtype
44e95e6 
Partially addresses pandas-devgh-15823.
@gfyoung gfyoung force-pushed the index-dtype-err-msg branch from 8719675 to 44e95e6 Compare June 11, 2018 21:08
@jreback
Copy link
Contributor

jreback commented Jun 12, 2018

yep looks fine. let's wait till 0.23.2 whatsnew is in (I see you have PR for that), but don't merge unless @TomAugspurger releases.

@gfyoung
Copy link
Member Author

gfyoung commented Jun 12, 2018 •
edited
Loading

let's wait till 0.23.2 whatsnew is in (I see you have PR for that), but don't merge unless @TomAugspurger releases.

Just to clarify: Are you saying to hold on both PR's until @TomAugspurger releases? Or just this one?

@jreback
Copy link
Contributor

jreback commented Jun 12, 2018

yes hold on both.

@jreback
Copy link
Contributor

jreback commented Jun 12, 2018

nvm this is fine.

@jreback jreback merged commit defdb34 into pandas-dev:master Jun 12, 2018
@gfyoung gfyoung deleted the index-dtype-err-msg branch June 12, 2018 00:18
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.23.2, 0.24.0 Jun 12, 2018
david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
@gfyoung @david-liu-brattle-1
MAINT: More friendly error msg on Index overflow (pandas-dev#21377)
8e0cc3a 
* MAINT: More useful error msg on Index overflow

Display a more friendly error message when there
is an OverflowError during Index construction.

Partially addresses pandas-devgh-15832.

* DOC: Clarify how Index.__new__ handles dtype

Partially addresses pandas-devgh-15823.
jorisvandenbossche pushed a commit that referenced this pull request Jun 29, 2018
@gfyoung @jorisvandenbossche
MAINT: More friendly error msg on Index overflow (#21377)
d67222b 
* MAINT: More useful error msg on Index overflow

Display a more friendly error message when there
is an OverflowError during Index construction.

Partially addresses gh-15832.

* DOC: Clarify how Index.__new__ handles dtype

Partially addresses gh-15823.

(cherry picked from commit defdb34)
jorisvandenbossche pushed a commit that referenced this pull request Jul 2, 2018
@gfyoung @jorisvandenbossche
MAINT: More friendly error msg on Index overflow (#21377)
22c5145 
* MAINT: More useful error msg on Index overflow

Display a more friendly error message when there
is an OverflowError during Index construction.

Partially addresses gh-15832.

* DOC: Clarify how Index.__new__ handles dtype

Partially addresses gh-15823.

(cherry picked from commit defdb34)
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@gfyoung
MAINT: More friendly error msg on Index overflow (pandas-dev#21377)
2ffe478 
* MAINT: More useful error msg on Index overflow

Display a more friendly error message when there
is an OverflowError during Index construction.

Partially addresses pandas-devgh-15832.

* DOC: Clarify how Index.__new__ handles dtype

Partially addresses pandas-devgh-15823.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Error Reporting Incorrect or improved errors from pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
0.23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@gfyoung @jreback @jorisvandenbossche