-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fixing 'a la' confusion in series.quantile documentation #21293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just stating that numpy.percentile also offers something similar to this
Hello @uds5501! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on June 06, 2018 at 06:04 Hours UTC |
followed PEP8 rules
Codecov Report
@@ Coverage Diff @@
## master #21293 +/- ##
==========================================
+ Coverage 91.85% 91.85% +<.01%
==========================================
Files 153 153
Lines 49546 49549 +3
==========================================
+ Hits 45509 45512 +3
Misses 4037 4037
Continue to review full report at Codecov.
|
pandas/core/series.py
Outdated
@@ -1837,7 +1837,8 @@ def round(self, decimals=0, *args, **kwargs): | |||
|
|||
def quantile(self, q=0.5, interpolation='linear'): | |||
""" | |||
Return value at the given quantile, a la numpy.percentile. | |||
Return value at the given quantile | |||
(you can also see numpy.percentile, much similar like series.quantile). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this just add numpy.percentile to the See Also section
@uds5501 general feedback: can you give the PR a more informative title? (you can still edit the title, see 'edit' button at the right of it) |
inserted numpy.percentile in See also section
@WillAyd Did the update you asked for. Now numpy.percentile is included in See also section |
@uds5501 Thanks a lot! |
Just stating that numpy.percentile also offers something similar to this
git diff upstream/master -u -- "*.py" | flake8 --diff