Skip to content

DOC: Fixing 'a la' confusion in series.quantile documentation #21293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2018

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 2, 2018

Just stating that numpy.percentile also offers something similar to this

Just stating that numpy.percentile also offers something similar to this
@pep8speaks
Copy link

pep8speaks commented Jun 2, 2018

Hello @uds5501! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on June 06, 2018 at 06:04 Hours UTC

@codecov
Copy link

codecov bot commented Jun 2, 2018

Codecov Report

Merging #21293 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21293      +/-   ##
==========================================
+ Coverage   91.85%   91.85%   +<.01%     
==========================================
  Files         153      153              
  Lines       49546    49549       +3     
==========================================
+ Hits        45509    45512       +3     
  Misses       4037     4037
Flag Coverage Δ
#multiple 90.25% <ø> (ø) ⬆️
#single 41.87% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/series.py 94.12% <ø> (ø) ⬆️
pandas/io/formats/csvs.py 98.14% <0%> (+0.01%) ⬆️
pandas/core/indexes/interval.py 93.16% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4274b84...194c5c1. Read the comment docs.

@@ -1837,7 +1837,8 @@ def round(self, decimals=0, *args, **kwargs):

def quantile(self, q=0.5, interpolation='linear'):
"""
Return value at the given quantile, a la numpy.percentile.
Return value at the given quantile
(you can also see numpy.percentile, much similar like series.quantile).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this just add numpy.percentile to the See Also section

@jreback jreback added the Docs label Jun 3, 2018
@jorisvandenbossche
Copy link
Member

@uds5501 general feedback: can you give the PR a more informative title? (you can still edit the title, see 'edit' button at the right of it)

inserted numpy.percentile in See also section
@uds5501 uds5501 changed the title Updating Docs Fixing 'a la' confusion in series.quantile documentation Jun 6, 2018
@uds5501
Copy link
Contributor Author

uds5501 commented Jun 6, 2018

@WillAyd Did the update you asked for. Now numpy.percentile is included in See also section

@jorisvandenbossche jorisvandenbossche changed the title Fixing 'a la' confusion in series.quantile documentation DOC: Fixing 'a la' confusion in series.quantile documentation Jun 6, 2018
@jorisvandenbossche jorisvandenbossche merged commit dd91539 into pandas-dev:master Jun 6, 2018
@jorisvandenbossche
Copy link
Member

@uds5501 Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: doc string is not very clear for Series.quantile
5 participants