DOC: Fix renaming categories section #21264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The categories were not correctly saved so that the renaming using the dict-like object had no effect.
WillAyd
approved these changes
May 30, 2018
jorisvandenbossche
changed the title
jorisvandenbossche
approved these changes
May 31, 2018
|
Thanks! @WillAyd I think in this case for such a minor doc fix it is fine to directly open a PR (we mainly want to avoid people doing bug fixes which might not be fixes or new features we might not want to include) |
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
The categories were not correctly saved so that the renaming using the dict-like object had no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The categories were not correctly saved so that the renaming using the
dict-like object had no effect.