Skip to content

DOC: Add numeric_only to DataFrame.quantile #21214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2018

Conversation

mroeschke
Copy link
Member

My confusion with #18608 was primarily due to the numeric_only not being specified in the docs. Additional we do have tests covering this case in pandas/tests/frame/test_quantile.py

@mroeschke mroeschke added the Docs label May 26, 2018
@codecov
Copy link

codecov bot commented May 26, 2018

Codecov Report

Merging #21214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21214   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         153      153           
  Lines       49505    49505           
=======================================
  Hits        45466    45466           
  Misses       4039     4039
Flag Coverage Δ
#multiple 90.23% <ø> (ø) ⬆️
#single 41.88% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 97.22% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6abb61...d3bae9e. Read the comment docs.

@jreback jreback added this to the 0.23.1 milestone May 29, 2018
@jreback jreback merged commit 7c522bf into pandas-dev:master May 29, 2018
@jreback
Copy link
Contributor

jreback commented May 29, 2018

thanks @mroeschke

@mroeschke mroeschke deleted the quantile_numeric_only branch May 29, 2018 04:49
jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Jun 8, 2018
jorisvandenbossche pushed a commit that referenced this pull request Jun 9, 2018
david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.quantile fails with timedelta data
3 participants