-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
fix hashing string-casting error #21187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0fab6a9
fix hashing string-casting error
jbrockmendel 24a0f59
flake8 fixup
jbrockmendel a879d69
Merge branch 'master' of https://github.com/pandas-dev/pandas into un…
jbrockmendel 279a6e1
add test in py3, whatsnew note in 0.23.1
jbrockmendel 3f8e9b2
fixup remove unused import
jbrockmendel 35ca0cd
Merge branch 'master' of https://github.com/pandas-dev/pandas into un…
jbrockmendel 9a37725
Merge branch 'master' of https://github.com/pandas-dev/pandas into un…
jbrockmendel 7f12013
make set_defaultencoding context
jbrockmendel 3b91c00
Move note to 0.23.2
jbrockmendel 7ab9324
Merge branch 'master' of https://github.com/pandas-dev/pandas into un…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -202,6 +202,42 @@ def test_latex_repr(self): | |
|
||
class TestCategoricalRepr(object): | ||
|
||
def test_categorical_repr_unicode(self): | ||
# GH#21002 if len(index) > 60, sys.getdefaultencoding()=='ascii', | ||
# and we are working in PY2, then rendering a Categorical could raise | ||
# UnicodeDecodeError by trying to decode when it shouldn't | ||
from pandas.core.base import StringMixin | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can import at the top |
||
|
||
class County(StringMixin): | ||
name = u'San Sebastián' | ||
state = u'PR' | ||
|
||
def __unicode__(self): | ||
return self.name + u', ' + self.state | ||
|
||
cat = pd.Categorical([County() for n in range(61)]) | ||
idx = pd.Index(cat) | ||
ser = idx.to_series() | ||
|
||
if compat.PY3: | ||
# no reloading of sys, just check that the default (utf8) works | ||
# as expected | ||
repr(ser) | ||
str(ser) | ||
|
||
else: | ||
# set sys.defaultencoding to ascii, then change it back after | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you make this into a context manager in pandas.util.testing |
||
# the test | ||
enc = sys.getdefaultencoding() | ||
reload(sys) # noqa:F821 | ||
sys.setdefaultencoding('ascii') | ||
try: | ||
repr(ser) | ||
str(ser) | ||
finally: | ||
# restore encoding | ||
sys.setdefaultencoding(enc) | ||
|
||
def test_categorical_repr(self): | ||
a = Series(Categorical([1, 2, 3, 4])) | ||
exp = u("0 1\n1 2\n2 3\n3 4\n" + | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move to 0.23.2