Skip to content

BUG: Fix interval_range when start/periods or end/periods are specified with float start/end #21162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2018

Conversation

jschendel
Copy link
Member

Should be good for 0.23.1; the code changes only hit the interval_range function, which is outside the IntervalIndex class, so should be independent of any enhancements related to IntervalIndex that we might want to push to 0.24.0.

@jschendel jschendel added this to the 0.23.1 milestone May 22, 2018
@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #21162 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21162   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         153      153           
  Lines       49505    49505           
=======================================
  Hits        45466    45466           
  Misses       4039     4039
Flag Coverage Δ
#multiple 90.23% <100%> (ø) ⬆️
#single 41.88% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/interval.py 93.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd04471...6520eb8. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented May 22, 2018

lgtm. looks like a conflict in whatsother. merge on fix. (note ok to add some blank lines in each of the bug fix sections to avoid future conflicts)

@jschendel jschendel merged commit be90d49 into pandas-dev:master May 23, 2018
@jschendel jschendel deleted the iv-rng-trunc branch May 23, 2018 04:22
jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Jun 8, 2018
jorisvandenbossche pushed a commit that referenced this pull request Jun 9, 2018
david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Interval Interval data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: interval_range is incorrect when start/periods or end/periods is specified with float start/end
3 participants