-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Improve docstring of Timedelta.delta #21135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4dcb4b4
updated docstring for nanoseconds function
chalmerlowe e0ae113
Merge remote-tracking branch 'upstream/master' into nanosecond-docstring
chalmerlowe 11a9266
DOC: updated docstring for nanoseconds function per doc guidelines
chalmerlowe 04e204b
DOC: added examples to nanoseconds function and minor formatting edits
chalmerlowe 5ac6ef1
DOC: added example header
chalmerlowe fb45759
DOC: added example header and space
chalmerlowe b0977f4
DOC: fixed minor spelling error
chalmerlowe 85bcb52
removed trailing whitespace, long lines
chalmerlowe 841611e
Merge remote-tracking branch 'upstream/master' into nanosecond-docstring
chalmerlowe 4237391
DOC: updates to docstring for nanoseconds function per doc guidelines
chalmerlowe 5035798
DOC: documentation guide update to resolution docstring
chalmerlowe 3a2fd38
Merge remote-tracking branch 'upstream/master' into delta-docstring
chalmerlowe e18e685
DOCL: Improve the docstring of Timedelta.delta
chalmerlowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already a part of #21122?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WillAyd
Yes...
I am not sure why that is in there.
I created separate branches for each of the changes I am proposing to:
etcetera, but the commit stream above seems to be sucking all of them into this PR.
super confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm this should just reflect what you have locally - any chance you merged your branches there accidentally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when creating a new branch, do it off of upstream/master (or if you keep a local master then off of this). each branch should be independent.
you will need to revert the resolution part of this change (as its in the other PR). or can just close that one and do it here is ok too)