-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Should not raise error in concatenating Series with numpy scalar and tuple names (GH21015) #21132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Should not raise error in concatenating Series with numpy scalar and tuple names (GH21015) #21132
Changes from 6 commits
13f00df
354eb2d
613ab4e
3e84f9c
35b664f
7ec0135
345c084
21d834e
ba8abba
8aa7e05
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2487,3 +2487,14 @@ def test_concat_aligned_sort_does_not_raise(): | |
columns=[1, 'a']) | ||
result = pd.concat([df, df], ignore_index=True, sort=True) | ||
tm.assert_frame_equal(result, expected) | ||
|
||
|
||
@pytest.mark.parametrize("s1name, s2name", [(np.int64(190), (43, 0)), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No space between There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
(190, (43, 0))]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could probably push the tuple on the above line down here - would make the indentation more readable There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done. Thanks |
||
def test_concat_series_name_npscalar_tuple(s1name, s2name): | ||
# GH21015 | ||
s1 = pd.Series({'a': 1, 'b': 2}, name=s1name) | ||
s2 = pd.Series({'c': 5, 'd': 6}, name=s2name) | ||
result = pd.concat([s1, s2]) | ||
expected = pd.Series({'a': 1, 'b': 2, 'c': 5, 'd': 6}) | ||
tm.assert_series_equal(result, expected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace ``Series`` with :class:`Series`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done