Skip to content

Pass sort for agg multiple #21062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2018

Conversation

TomAugspurger
Copy link
Contributor

xref #20909

@TomAugspurger TomAugspurger added this to the 0.23.0 milestone May 15, 2018
@TomAugspurger
Copy link
Contributor Author

cc @jorisvandenbossche


tm.assert_frame_equal(result, expected)

# unsorted index. Still sorts the index for backwards compat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean with "Still sorts the index for backwards compat"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we pass .agg(['sum', 'min']) the result's index is the sorted function names, ['min', 'sum']. Make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could imaging preserving the function order here someday, but would need to deprecate first.

Copy link
Contributor Author

@TomAugspurger TomAugspurger May 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update the comment to say "Still sorts the result's index"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok, the sorting is about the [sum, min] axis, then I understand

@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #21062 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21062   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files         153      153           
  Lines       49503    49503           
=======================================
  Hits        45458    45458           
  Misses       4045     4045
Flag Coverage Δ
#multiple 90.22% <100%> (ø) ⬆️
#single 41.88% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/base.py 96.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb2651...ac0d1f5. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

CI passed. Pushing a clarifying comment and merging.

@TomAugspurger TomAugspurger merged commit 90f638f into pandas-dev:master May 15, 2018
@TomAugspurger TomAugspurger deleted the agg-apply-warning branch May 15, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants