Add epoch alternative to deprecation message #21060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/_libs/tslibs/timedeltas.pyx
Outdated
| @@ -1196,6 +1196,9 @@ class Timedelta(_Timedelta): | |||
| msg = textwrap.dedent("""\ | |||
| Floor division between integer array and Timedelta is | |||
| deprecated. Use 'array // timedelta.value' instead. | |||
| If you want to obtain epochs from an array of timestamps, | |||
| you can rather use | |||
| 'array - pd.Timestamp("1970-01-01")) // pd.Timedelta('1s')'. | |||
There was a problem hiding this comment.
maybe double quotes for the Timedelta('1s') just for clarity
TomAugspurger
approved these changes
May 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #21060 +/- ##
=======================================
Coverage 91.82% 91.82%
=======================================
Files 153 153
Lines 49503 49503
=======================================
Hits 45458 45458
Misses 4045 4045
Continue to review full report at Codecov.
|
zertrin
added a commit
to zertrin/pandas
that referenced
this pull request
May 22, 2018
TomAugspurger
pushed a commit
that referenced
this pull request
May 22, 2018
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Jun 8, 2018
…s-dev#21170) (cherry picked from commit cd04471)
jorisvandenbossche
pushed a commit
that referenced
this pull request
Jun 9, 2018
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfr #21036 (comment)