Fix Inconsistent MultiIndex Sorting #21043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21043 +/- ##
==========================================
- Coverage 91.82% 91.82% -0.01%
==========================================
Files 153 153
Lines 49503 49503
==========================================
- Hits 45458 45457 -1
- Misses 4045 4046 +1
Continue to review full report at Codecov.
|
|
Just added a test and fix to cover Series as well, as we had another related issue pop up cc @kdebrab |
jreback
added
Bug
Indexing
|
lgtm. @toobaz if you'd have a quick look. merge if ok. |
|
thanks @WillAyd very nice! |
4 tasks
|
Does this need a whatsnew? |
|
@jorisvandenbossche I can add one. Should I just open a separate PR for that? |
|
If you think it is needed (if there are user facing changes), then a new PR is perfect |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Jun 8, 2018
(cherry picked from commit bc37ea2)
jorisvandenbossche
pushed a commit
that referenced
this pull request
Jun 9, 2018
(cherry picked from commit bc37ea2)
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20994
closes #20945
closes #21052
git diff upstream/master -u -- "*.py" | flake8 --diffThis is a pretty dark corner and I'll admit that I don't fully understand all of the elements in play. That said, the first problem I noticed with the first referenced issue was an errant conditional that was causing
level=0andlevel='foo'to go down two different branches, even if the name of the first level was in fact 'foo'.After uncovering that, the subsequent ordering of the returned index then was incorrect regardless of the argument. I moved a monotonic sort around to fix this, though I feel like:
Feedback appreciated