TST: add arithmetic operators fixture #21033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
small work on this. |
Codecov Report
@@ Coverage Diff @@
## master #21033 +/- ##
==========================================
+ Coverage 91.82% 91.82% +<.01%
==========================================
Files 153 153
Lines 49502 49502
==========================================
+ Hits 45455 45457 +2
+ Misses 4047 4045 -2
Continue to review full report at Codecov.
|
WillAyd
reviewed
May 14, 2018
| dt2.iloc[2] = np.nan | ||
| td1 = Series(timedelta_range('1 days 1 min', periods=5, freq='H')) | ||
| td2 = td1.copy() | ||
| td2.iloc[1] = np.nan |
There was a problem hiding this comment.
Is this missing a check for dt2 and td2?
pandas/conftest.py
Outdated
| @pytest.fixture(params=_all_arithmetic_operators) | ||
| def all_arithmetic_operators(request): | ||
| """ | ||
| Fixture for common arithmetic operations |
There was a problem hiding this comment.
Maybe say that these are the dunder names? Otherwise unclear whether it's the like __div__ or div or operator.div.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.