ENH: Implement linspace behavior for timedelta_range and interval_range #21009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
commented
May 11, 2018
| if data is None and freq is None \ | ||
| and com._any_none(periods, start, end): | ||
| raise ValueError("Must provide freq argument if no data is " | ||
| "supplied") |
There was a problem hiding this comment.
small refactor here; moved this code a few lines down so all the if data is None: code is in one place.
Codecov Report
@@ Coverage Diff @@
## master #21009 +/- ##
==========================================
+ Coverage 91.82% 91.82% +<.01%
==========================================
Files 153 153
Lines 49491 49505 +14
==========================================
+ Hits 45446 45460 +14
Misses 4045 4045
Continue to review full report at Codecov.
|
jreback
added
Enhancement
Timedelta
|
nice patch @jschendel ! Ideally we could add a small doc-update in timeseries: http://pandas-docs.github.io/pandas-docs-travis/timeseries.html#generating-ranges-of-timestamps and in the timedelta / interval sections if appropriate. |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 13, 2018
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffSummary:
timedelta_rangeinterval_rangetest_interval_range.pyto useparametrize; split up some testsbdate_rangeto ensure thatfreqis specifiedbdate_rangeimplies a frequencydate_range; could get linspace behavior by overridingfreqtoNone*_rangefunctions exceptperiod_range