API: Added axis to take #20999
Merged
API: Added axis to take #20999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
Indexing
Codecov Report
@@ Coverage Diff @@
## master #20999 +/- ##
=======================================
Coverage 91.82% 91.82%
=======================================
Files 153 153
Lines 49491 49491
=======================================
Hits 45446 45446
Misses 4045 4045
Continue to review full report at Codecov.
|
|
lgtm. thanks @TomAugspurger |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 13, 2018
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axiskeyword in pandas.core.algorithms.take #20932git diff upstream/master -u -- "*.py" | flake8 --diffOne thing that's worrisome here: for N-D arrays, the
fill_valueargument is set for each element. In the case of IPArray, this is fine, since my storage NA-value is (0, 0), so I would passfill_value=0. But in general, when people are using an N-D array to back a 1-D column, that won't necessarily work. But at that point, maybe we recommend people implement take on their own.