BUG: Fix isna cannot handle ambiguous typed list #20971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licht-T
force-pushed
the
fix-isna-behavior-for-lists
branch
from
13bf3de to
27a8d55
Compare
Codecov Report
@@ Coverage Diff @@
## master #20971 +/- ##
==========================================
- Coverage 91.82% 91.81% -0.01%
==========================================
Files 153 153
Lines 49483 49487 +4
==========================================
Hits 45437 45437
- Misses 4046 4050 +4
Continue to review full report at Codecov.
|
jreback
added
Bug
Missing-data
jreback
requested changes
May 7, 2018
| @@ -120,7 +120,9 @@ def _isna_new(obj): | |||
| return _isna_ndarraylike(obj) | |||
| elif isinstance(obj, ABCGeneric): | |||
| return obj._constructor(obj._data.isna(func=isna)) | |||
| elif isinstance(obj, list) or hasattr(obj, '__array__'): | |||
| elif isinstance(obj, list): | |||
There was a problem hiding this comment.
can you make the same change in _isna_old
Licht-T
force-pushed
the
fix-isna-behavior-for-lists
branch
from
27a8d55 to
9b87fe7
Compare
|
Thanks @jreback, fixed! |
jreback
approved these changes
May 8, 2018
|
thanks @Licht-T |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff