Allow drop bins when using the cut function #20947

FANGOD · 2018-05-04T02:48:21Z

if cut(x, bins=[0, 1, 2, 3, 4, 5, 6, 6, 8, 8, 10], labels=False, retbins=True, right=False) will raise ValueError: You can drop duplicate edges by setting the 'duplicates' kwarg, so add 'duplicates' parameters to the cut function.

codecov · 2018-05-04T03:30:35Z

Codecov Report

❗ No coverage uploaded for pull request base (master@8e2a4a9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #20947   +/-   ##
=========================================
  Coverage          ?   91.82%           
=========================================
  Files             ?      153           
  Lines             ?    49488           
  Branches          ?        0           
=========================================
  Hits              ?    45443           
  Misses            ?     4045           
  Partials          ?        0

Flag	Coverage Δ
#multiple	`90.22% <ø> (?)`
#single	`41.85% <ø> (?)`

Impacted Files	Coverage Δ
pandas/core/reshape/tile.py	`93.37% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2a4a9...46c9bca. Read the comment docs.

jreback

ok would need:

a doc-strings update
tests, see how testing is done for qcut

pep8speaks · 2018-05-05T04:01:25Z

Hello @FANGOD! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on May 10, 2018 at 18:27 Hours UTC

FANGOD · 2018-05-05T05:20:09Z

duplicates=drop drop non-uniques

>>> pd.cut(s, [0, 2, 4, 6, 10, 10], labels=False, retbins=True,
...    right=False, duplicates='drop')
... # doctest: +ELLIPSIS
(a    0.0
 b    1.0
 c    2.0
 d    3.0
 e    3.0
 dtype: float64, array([0, 2, 4, 6, 8]))

jreback

the doc-string is fine, but we need an actual test (checking the duplicates kw in test_tile.py), follow the pattern of how qcut is tested

also need a whatsnew entry

jreback · 2018-05-05T12:50:54Z

pandas/core/reshape/tile.py

@@ -65,6 +65,8 @@ def cut(x, bins, right=True, labels=None, retbins=False, precision=3,
        The precision at which to store and display the bins labels.
    include_lowest : bool, default False
        Whether the first interval should be left-inclusive or not.
+    duplicates : {default 'raise', 'drop'}, optional
+        If bin edges are not unique, raise ValueError or drop non-uniques.


add a versionadded tag

add a Raises part of the doc-string

FANGOD · 2018-05-09T01:45:16Z

I don't know what to do. Your ci is too 666.

jreback · 2018-05-09T10:27:34Z

pandas/core/reshape/tile.py

@@ -65,6 +65,12 @@ def cut(x, bins, right=True, labels=None, retbins=False, precision=3,
        The precision at which to store and display the bins labels.
    include_lowest : bool, default False
        Whether the first interval should be left-inclusive or not.
+    duplicates : {default 'raise', 'drop'}, optional
+        If bin edges are not unique, raise ValueError("Bin edges must be 


you dont need to show the error message here.

instead add a Returns section in the doc-string, showing that a ValueError can be raised

jreback · 2018-05-09T10:28:18Z

pandas/core/reshape/tile.py

+     e    4.0
+     dtype: float64, array([0, 2, 4, 6, 8]))
+
+    ``duplicates=drop`` drop non-uniques


make this a sentence

jreback · 2018-05-09T10:28:57Z

pandas/tests/test_tile.py

+
+
+class TestCut(object):
+


don't add a new file, put in pandas/tests/reshaping/test_tile.py

Sorry, I didn't find it before.

jreback · 2018-05-10T10:25:05Z

ok linted and added a test. ping on green.

jreback · 2018-05-10T18:27:52Z

thanks @FANGOD

FANGOD · 2018-05-11T02:11:25Z

Finally. Good experience.

Allow drop bins when using the cut function

c9ec7de

jreback requested changes May 4, 2018

View reviewed changes

jreback added Enhancement Indexing Related to indexing on series/frames, not to indexes themselves Reshaping Concat, Merge/Join, Stack/Unstack, Explode Interval Interval data type labels May 4, 2018

FANGOD added 2 commits May 5, 2018 11:08

added parameters

dbf8cc2

added examples to the cut function

6b8babf

FANGOD added 2 commits May 5, 2018 12:07

Modify according to PEP8

1ec414b

Allow drop bins when using the cut function

2b0e07b

jreback requested changes May 5, 2018

View reviewed changes

FANGOD added 4 commits May 7, 2018 14:49

add test_tile.py

2ac70fe

Update test_tile.py

251d007

add a versionadded tag and update doc-string

9b7eec3

add a whatsnew entry for 'duplicates' option

8b2650d

jreback requested changes May 9, 2018

View reviewed changes

FANGOD and others added 6 commits May 10, 2018 14:56

Update some

8ff6fd5

Update some

9376d01

Update some

6b054ba

Merge branch 'master' into PR_TOOL_MERGE_PR_20947

b0b63e2

lint

185758e

add test

987856f

jreback approved these changes May 10, 2018

View reviewed changes

jreback added this to the 0.23.0 milestone May 10, 2018

Merge branch 'master' into PR_TOOL_MERGE_PR_20947

46c9bca

jreback merged commit c30f0bb into pandas-dev:master May 10, 2018

topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 13, 2018

Allow drop bins when using the cut function (pandas-dev#20947)

9dbefa3

topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 13, 2018

Allow drop bins when using the cut function (pandas-dev#20947)

cb42426

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow drop bins when using the cut function #20947

Allow drop bins when using the cut function #20947

FANGOD commented May 4, 2018 •

edited

Loading

codecov bot commented May 4, 2018 •

edited

Loading

jreback left a comment

pep8speaks commented May 5, 2018 •

edited

Loading

FANGOD commented May 5, 2018

jreback left a comment

jreback May 5, 2018

FANGOD commented May 9, 2018 •

edited

Loading

jreback May 9, 2018

jreback May 9, 2018

jreback May 9, 2018

jreback May 9, 2018

FANGOD May 10, 2018

jreback commented May 10, 2018

jreback commented May 10, 2018

FANGOD commented May 11, 2018



		class TestCut(object):

Allow drop bins when using the cut function #20947

Allow drop bins when using the cut function #20947

Conversation

FANGOD commented May 4, 2018 • edited Loading

codecov bot commented May 4, 2018 • edited Loading

Codecov Report

jreback left a comment

Choose a reason for hiding this comment

pep8speaks commented May 5, 2018 • edited Loading

Comment last updated on May 10, 2018 at 18:27 Hours UTC

FANGOD commented May 5, 2018

jreback left a comment

Choose a reason for hiding this comment

jreback May 5, 2018

Choose a reason for hiding this comment

FANGOD commented May 9, 2018 • edited Loading

jreback May 9, 2018

Choose a reason for hiding this comment

jreback May 9, 2018

Choose a reason for hiding this comment

jreback May 9, 2018

Choose a reason for hiding this comment

jreback May 9, 2018

Choose a reason for hiding this comment

FANGOD May 10, 2018

Choose a reason for hiding this comment

jreback commented May 10, 2018

jreback commented May 10, 2018

FANGOD commented May 11, 2018

FANGOD commented May 4, 2018 •

edited

Loading

codecov bot commented May 4, 2018 •

edited

Loading

pep8speaks commented May 5, 2018 •

edited

Loading

FANGOD commented May 9, 2018 •

edited

Loading