Fixes Update docs on reserved attributes #20878 #20933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20933 +/- ##
=========================================
Coverage ? 91.81%
=========================================
Files ? 153
Lines ? 49478
Branches ? 0
=========================================
Hits ? 45429
Misses ? 4049
Partials ? 0
Continue to review full report at Codecov.
|
jreback
requested changes
May 3, 2018
doc/source/indexing.rst
Outdated
| @@ -235,7 +235,7 @@ as an attribute: | |||
| - The attribute will not be available if it conflicts with an existing method name, e.g. ``s.min`` is not allowed. | |||
|
|
|||
| - Similarly, the attribute will not be available if it conflicts with any of the following list: ``index``, | |||
| ``major_axis``, ``minor_axis``, ``items``, ``labels``. | |||
| ``major_axis``, ``minor_axis``, ``items``, ``labels``. However, in 0.23.0 and later, ``labels`` will be available. | |||
There was a problem hiding this comment.
just remove it from the list instead.
jreback
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff