Skip to content

BUG: fix indexing.py to make a copy of the indices (#20852) #20855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

BUG: fix indexing.py to make a copy of the indices (#20852) #20855

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adde2bd
Fixes #20852 - Fix indexing.py to make a copy of the indices
Apr 28, 2018
103d41d
Fix linting issue in 'indexing.py'
May 2, 2018
6b0a872
Create a Copy the indices only when it's going to be changed
May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2413,6 +2413,9 @@ def maybe_convert_indices(indices, n):
# If list is empty, np.array will return float and cause indexing
# errors.
return np.empty(0, dtype=np.int_)
else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move the copy to inside mask.any() check as its only needed there. use indices.copy()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review comments. I have made the changes as suggested.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add new testcases for this change .

# create a copy of indices
indices = np.array(indices, copy=True)

mask = indices < 0
if mask.any():
Expand Down