Skip to content

[WIP] Debug R doc build failure #20830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Apr 26, 2018

The packages built by anaconda include compiler flags (-fPIC) that should make this error impossible. Seeing if (temporarily) excluding conda-forge packages fixes things.

@pep8speaks
Copy link

pep8speaks commented Apr 26, 2018

Hello @TomAugspurger! Thanks for updating the PR.

Line 75:13: E128 continuation line under-indented for visual indent

Comment last updated on April 26, 2018 at 14:14 Hours UTC

@codecov
Copy link

codecov bot commented Apr 26, 2018

Codecov Report

Merging #20830 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20830   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         153      153           
  Lines       49281    49281           
=======================================
  Hits        45230    45230           
  Misses       4051     4051
Flag Coverage Δ
#multiple 90.17% <ø> (ø) ⬆️
#single 41.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630ef16...d6e9466. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

Hmm, still trying to get a local reproducer, but https://travis-ci.org/pandas-dev/pandas/jobs/371582150#L2705 managed to import rpy2, I guess since it was imported early enough :/

https://stackoverflow.com/questions/19268293/matlab-error-cannot-open-with-static-tls/19468365#19468365

It sounds like either Travis' glibc is the bottleneck here. We won't be able to do much to work around it unfortunately.

@jorisvandenbossche
Copy link
Member

Thanks for looking into this.
Temporary / definite workaround would be just remove that doc section, or to convert it to static code-blocks.

@TomAugspurger
Copy link
Contributor Author

Yeah. I'm able to build things locally, so I'm not too worried about it delaying the relase.

@jreback
Copy link
Contributor

jreback commented Nov 1, 2018

closing as stale. if you'd like to continue pls ping.

@jreback jreback closed this Nov 1, 2018
@TomAugspurger TomAugspurger deleted the rpy2-debug branch November 2, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants