TST: Fixed failures in JSON asserts #20827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an occasional failure in the json tests. They'd fail when the
Series held objects of equal length.
```pytb
pandas/tests/extension/json/test_json.py:114:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
pandas/util/testing.py:1224: in assert_series_equal
_testing.assert_almost_equal(left.get_values(), right.get_values(),
pandas/core/series.py:466: in get_values
return self._data.get_values()
pandas/core/internals.py:4742: in get_values
return np.array(self._block.to_dense(), copy=False)
pandas/core/internals.py:1940: in to_dense
return np.asarray(self.values)
../../Envs/pandas-dev/lib/python3.6/site-packages/numpy/numpy/core/numeric.py:500: in asarray
return array(a, dtype, copy=False, order=order)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = {'a': 1}, key = 0
def __getitem__(self, key):
if key in self.data:
return self.data[key]
if hasattr(self.__class__, "__missing__"):
return self.__class__.__missing__(self, key)
> raise KeyError(key)
E KeyError: 0
```
Work around that by converting to dicts before comparing.
TomAugspurger
added
the
ExtensionArray
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #20827 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 153 153
Lines 49281 49281
=======================================
Hits 45230 45230
Misses 4051 4051
Continue to review full report at Codecov.
|
|
Apologies for the quick self-merge, but I'm going to merge this on green so that #20814 can be re-run on top if it. This is test-only so I think things are OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an occasional failure in the json tests. They'd fail when the
Series held objects of equal length.
pandas/tests/extension/json/test_json.py:114: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ pandas/util/testing.py:1224: in assert_series_equal _testing.assert_almost_equal(left.get_values(), right.get_values(), pandas/core/series.py:466: in get_values return self._data.get_values() pandas/core/internals.py:4742: in get_values return np.array(self._block.to_dense(), copy=False) pandas/core/internals.py:1940: in to_dense return np.asarray(self.values) ../../Envs/pandas-dev/lib/python3.6/site-packages/numpy/numpy/core/numeric.py:500: in asarray return array(a, dtype, copy=False, order=order) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = {'a': 1}, key = 0 def __getitem__(self, key): if key in self.data: return self.data[key] if hasattr(self.__class__, "__missing__"): return self.__class__.__missing__(self, key) > raise KeyError(key) E KeyError: 0Work around that by converting to dicts before comparing.