Accessor registry #20780
Merged
Accessor registry #20780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-using the _accessors attribute, since nothing seemed to rely on it being a frozenset. Closes pandas-dev#19963
|
Do we want to document this as the official way to get a list of the registered accessors for an object? |
jreback
added
the
Compat
Codecov Report
@@ Coverage Diff @@
## master #20780 +/- ##
==========================================
+ Coverage 91.84% 91.84% +<.01%
==========================================
Files 153 153
Lines 49305 49307 +2
==========================================
+ Hits 45284 45286 +2
Misses 4021 4021
Continue to review full report at Codecov.
|
|
lgtm. ok to update docs / merge. |
Do you want to use this in eg Dask? |
|
I think the current preference is for authors to explicitly register their
accessors with Dask as well.
Let's leave it private for now, and if people need it later on we will
document it.
…On Mon, Apr 23, 2018 at 2:29 AM, Joris Van den Bossche < ***@***.***> wrote:
Do we want to document this as the official way to get a list of the
registered accessors for an object?
Do you want to use this in eg Dask?
If so, then maybe we should document that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20780 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIsd868SRfXfGI3BVI_OFQJuo1BVlks5trYLVgaJpZM4TekOV>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19963
cc @datapythonista I think this would have solved your issues w/ the validation script.