BUG: Fix a bug in plotting when using color array. #20726 #20727
Conversation
|
you would need a test for this & a whatsnew entry. |
Codecov Report
@@ Coverage Diff @@
## master #20727 +/- ##
=======================================
Coverage 31.89% 31.89%
=======================================
Files 166 166
Lines 52421 52421
=======================================
Hits 16722 16722
Misses 35699 35699
Continue to review full report at Codecov.
|
|
Can you merge master for this? |
|
Hello @wuhaochen! Thanks for updating the PR.
|
|
@jreback is anything else needed here, or can this be merged? |
pandas/tests/plotting/test_misc.py
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| import pytest | |||
|
|
|||
| import pandas as pd | |||
There was a problem hiding this comment.
I don't think we need this extra import since DataFrame (which your test uses) is already imported below.
pandas/tests/plotting/test_misc.py
Outdated
| 1, color=color_before) | ||
| assert len(color_after) == len(color_before) | ||
|
|
||
| df = pd.DataFrame(np.random.randn(48, 4), |
|
looks fine. if someone wants to push the changes @mroeschke suggested would be great. @WillAyd any comments. |
|
thanks @wuhaochen |
git diff master --name-only -- "*.py" | flake8