Skip to content

DEP: Add 'python_requires' to setup.py to drop 3.4 support #20698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2018
Merged

DEP: Add 'python_requires' to setup.py to drop 3.4 support #20698

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36fa2ae
DEP: Add 'python_requires' to setup.py to drop 3.4 support
djhoese Apr 14, 2018
a3c306d
Fix 'python_requires' to include python 2.7
djhoese Apr 15, 2018
24a9270
Update setuptools minimum version to 24.2.0
djhoese Apr 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,4 +748,5 @@ def pxd(name):
long_description=LONG_DESCRIPTION,
classifiers=CLASSIFIERS,
platforms='any',
python_requires='>2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*',
Copy link
Contributor

@jreback jreback Apr 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, there has to be a better way to write this, to signify only 2.7 or >=3.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following numpy (https://github.com/numpy/numpy/blob/master/setup.py#L368) and the link I mentioned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://packaging.python.org/tutorials/distributing-packages/?highlight=python_requires#python-requires

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it should be simpler but wasn't sure what conditionals were allowed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I do notice a big mistake. It should be >=2.7 not >2.7. Researching to see if there is a shorter way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

In [15]: from pip.utils.packaging import specifiers, version

In [16]: version.parse('3.5.0') in specifiers.SpecifierSet('==2.7,>=3.5.*')
Out[16]: False

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do >=3.5 ?

**setuptools_kwargs)