BUG: Series.is_unique has extra output if contains objects with __ne__ defined #20691
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20691 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 153 153
Lines 49275 49275
=======================================
Hits 45255 45255
Misses 4020 4020
Continue to review full report at Codecov.
|
| @@ -870,7 +870,7 @@ cdef class PyObjectHashTable(HashTable): | |||
| for i in range(n): | |||
| val = values[i] | |||
| hash(val) | |||
| if not _checknan(val): | |||
There was a problem hiding this comment.
i think this might be the only usage of checknan. can you remove it (from util.pxd) and see?
There was a problem hiding this comment.
seemed to be. There was an import to remove in hashtable and the definition in util. Removing them passed tests on my laptop. Have pushed new version.
doc/source/whatsnew/v0.23.0.txt
Outdated
| @@ -1175,3 +1175,4 @@ Other | |||
| - Improved error message when attempting to use a Python keyword as an identifier in a ``numexpr`` backed query (:issue:`18221`) | |||
| - Bug in accessing a :func:`pandas.get_option`, which raised ``KeyError`` rather than ``OptionError`` when looking up a non-existant option key in some cases (:issue:`19789`) | |||
| - Bug in :func:`assert_series_equal` and :func:`assert_frame_equal` for Series or DataFrames with differing unicode data (:issue:`20503`) | |||
| - Bug in ``Series.is_unique`` where extraneous output in stderr is shown if Series contains objects with ``__ne__`` defined (:issue:`20661`) | |||
jreback
added
Indexing
|
@jreback Removing checknan works, but failure was due to a network area with Amazon S3. How can I get the travis run to be done again? |
|
thanks @Dr-Irv yeah sometimes the builds fail for extraneous reasons. you can push a dummy commit if you want, e.g.
|
git diff upstream/master -u -- "*.py" | flake8 --diffSimple change from
_checknantochecknullin pandas/_libs/hashtable_class_helper.pxi.inChecked performance, and there is no difference.