Skip to content

Np Any/All Transformation Bug #20655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2018
Merged

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Apr 11, 2018

I believe this can be added to the whitelist of Cython functions as a result of #19722. I did similar changes with other agg funcs and will review separately to see if we should be adding more to this dict

@WillAyd WillAyd changed the title Np any all bug Np Any/All Transformation Bug Apr 11, 2018
@codecov
Copy link

codecov bot commented Apr 11, 2018

Codecov Report

Merging #20655 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20655      +/-   ##
==========================================
+ Coverage   91.81%   91.83%   +0.02%     
==========================================
  Files         153      153              
  Lines       49270    49270              
==========================================
+ Hits        45238    45248      +10     
+ Misses       4032     4022      -10
Flag Coverage Δ
#multiple 90.22% <ø> (+0.02%) ⬆️
#single 41.9% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/base.py 96.79% <ø> (ø) ⬆️
pandas/util/testing.py 84.38% <0%> (-0.21%) ⬇️
pandas/plotting/_converter.py 66.81% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa24af9...bb845fa. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Apr 11, 2018

can you add a comprehensive test for all np.* functions in .transform? similar to https://github.com/pandas-dev/pandas/pull/19670/files (add a fixture to pandas/conftest.py)

ok in next PR (unless straightforward here). lmk.

@jreback jreback added Bug Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Apr 11, 2018
@WillAyd
Copy link
Member Author

WillAyd commented Apr 11, 2018

Sure happy to do that. Need to think through the best way to test the return of each function but seems reasonable.

Would prefer to do in separate PR as the scope of that probably departs a little too far from this fix

@jreback jreback added this to the 0.23.0 milestone Apr 14, 2018
@jreback jreback merged commit fe0861e into pandas-dev:master Apr 14, 2018
@jreback
Copy link
Contributor

jreback commented Apr 14, 2018

thanks @WillAyd

@WillAyd WillAyd deleted the np-any-all-bug branch April 14, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform with np.any / np.all and NA in Group Raises
3 participants