Skip to content

added check if categoricalDtype for issue #19278 #20644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

xchoudhury
Copy link

@xchoudhury xchoudhury commented Apr 10, 2018

Checklist for other PRs:

@pep8speaks
Copy link

pep8speaks commented Apr 10, 2018

Hello @xchoudhury! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on April 10, 2018 at 03:36 Hours UTC

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #20644 into master will decrease coverage by <.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20644      +/-   ##
==========================================
- Coverage   91.83%   91.83%   -0.01%     
==========================================
  Files         153      153              
  Lines       49269    49276       +7     
==========================================
+ Hits        45247    45251       +4     
- Misses       4022     4025       +3
Flag Coverage Δ
#multiple 90.22% <28.57%> (-0.01%) ⬇️
#single 41.9% <14.28%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/sparse/series.py 93.75% <28.57%> (-1.46%) ⬇️
pandas/util/testing.py 84.59% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f206d...90756c6. Read the comment docs.

@gfyoung gfyoung added the Docs label Apr 10, 2018
@jorisvandenbossche jorisvandenbossche added Sparse Sparse Data Type Categorical Categorical Data Type and removed Docs labels Apr 10, 2018
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs

  • test
  • whatsnew entry (bug fix)

@TomAugspurger
Copy link
Contributor

@xchoudhury can you update?

@jreback
Copy link
Contributor

jreback commented Oct 11, 2018

closing as stale, if you want to continue working, pls ping and we can re-open. you will need to merge master.

@jreback jreback closed this Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Sparse Sparse Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour of Categorical inputs to sparse data structures
6 participants