CLN: cleanup tox.ini, remove stale pandas/setup.py, fix tox warning #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tox was complaining about "this is the wrong setup.py to use" because tox.ini was manually invoking pandas/setup.py, which has been superceeed by the root setup.py - the use of changedir= has been made clearer. - now removes the pandas uninstall from the venv after the tests. (but only if they succeed due to a limitation in tox)
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always find it hard to get Packaging issues right, i'd appreciate if someone
would back me up on pandas/setup.py being superfluous.
I made sure that setup.py install/develop still works, and that introducing
a failed test is caught by tox as you would expect,
Also see #2029 for much faster tox runs.