Skip to content

BUG: fix Series repr when name is tuple holding non string-type #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

lodagro
Copy link
Contributor

@lodagro lodagro commented Oct 11, 2012

Not sure if this is in line with latest unicode work, @y-p?

@ghost
Copy link

ghost commented Oct 11, 2012

on git master the test fails with

File "src/pandas/pandas/core/format.py", line 88, in _get_footer
series_name = "('%s')" % "', '".join(self.series.name)
TypeError: sequence item 0: expected string, int found

the test in b837101 already passes with (PR #2005).
as a side note, the PR excises stringify and stringify_seq in favor of a new pprint_thing(),
which should handle more corner-cases and is clearer about unicode/str issues.
a lot of that PR is migrating things over to using that, so it'd be nice if they weren't reintroduced by
new patches if possible.

@ghost
Copy link

ghost commented Oct 11, 2012

I vote to keep the test of course.

@lodagro
Copy link
Contributor Author

lodagro commented Oct 11, 2012

So what do we do? Is it ok that you add the test in #2005?

@ghost
Copy link

ghost commented Oct 11, 2012

Done. 11dff0d
note that I rewrite the PR as i go along to keep things tidy, so the SHA may change.

@lodagro
Copy link
Contributor Author

lodagro commented Oct 12, 2012

Ok, closing this one as it is redundant now.
Hopefully #2005 gets merged in soon, which will also close #2051.

@lodagro lodagro closed this Oct 12, 2012
@wesm
Copy link
Member

wesm commented Oct 12, 2012

Thanks. I'll review and merge #2005 as soon as I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants