BUG: .unique() on MultiIndex: preserve names #20571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Mar 31, 2018
pandas/tests/indexes/test_multi.py
Outdated
| tm.assert_index_equal(res, exp) | ||
|
|
||
| # GH #20568 - empty MI | ||
| mi = pd.MultiIndex.from_arrays([[], []], names=['first', 'second']) |
There was a problem hiding this comment.
can u add a test w/o names as well
Codecov Report
@@ Coverage Diff @@
## master #20571 +/- ##
==========================================
- Coverage 91.84% 91.82% -0.03%
==========================================
Files 152 152
Lines 49270 49269 -1
==========================================
- Hits 45252 45239 -13
- Misses 4018 4030 +12
Continue to review full report at Codecov.
|
|
@jreback ready to merge if there are no further comments |
jreback
reviewed
Apr 1, 2018
| @@ -2483,6 +2493,11 @@ def test_unique_level(self, level): | |||
| expected = mi.get_level_values(level) | |||
| tm.assert_index_equal(result, expected) | |||
|
|
|||
| # With empty MI | |||
| mi = pd.MultiIndex.from_arrays([[], []], names=['first', 'second']) | |||
| result = mi.unique(level=level) | |||
There was a problem hiding this comment.
does this also solve the case where no level is specified?
There was a problem hiding this comment.
No, the previous test does.
|
lgtm. merge away @toobaz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff