-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH/DOC: update pandas-gbq signature and docstring #20564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ea52387
DOC: intersphinx to pandas-gbq
tswast b1b1479
DOC: add detailed docs for read_gbq, to_gbq back.
tswast 0429227
CLN: line lengths.
tswast bee847b
DOC: remove dead link to pandas.io.to_gbq
tswast 2e5b148
DOC: update versionadded string for pandas-gbq
tswast cb178d9
Add pandas-gbq args to function signature directly.
tswast f09d38e
DOC: cross-reference to_gbq and read_gbq
tswast b6fdf37
Fix lint error.
tswast 37b2a08
DOC: render BigQuery auth flows as links
tswast f6c38f0
DOC: pandas-gbq to whatsnew
tswast 0889d6d
DOC: sync pandas-gbq changes from 0.4.0 (deprecate verbosity)
tswast aa99d47
DOC: clarify Pandas-GBQ version in whatsnew.
tswast 1ab0934
move whatsnew
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to stay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The validation script was complaining about this one. I think because this is a method of
DataFrame
, so there is nodataframe
argument. (I also triedself
and it complained about that, too.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh don’t worry about that too much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @tswast is correct that this should be removed. The method does not take a dataframe as input (it is writing
self
to gbq)