[WIP] Complete offset prefix mapping #20562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Easter` was the only offset class without prefix,
jreback
requested changes
Apr 1, 2018
pandas/tseries/offsets.py
Outdated
| CustomBusinessMonthEnd, # 'CBM' | ||
| CustomBusinessMonthBegin, # 'CBMS' | ||
| CustomBusinessHour, # 'CBH' | ||
| Day, # 'D' | ||
| Easter, # 'EASTER' |
There was a problem hiding this comment.
don't need Easter in this list
|
Hello @tv3141! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on April 02, 2018 at 12:06 Hours UTC |
jbrockmendel
reviewed
Aug 9, 2018
| CustomBusinessMonthEnd, # 'CBM' | ||
| CustomBusinessMonthBegin, # 'CBMS' | ||
| CustomBusinessHour, # 'CBH' |
There was a problem hiding this comment.
What’s the logic behind reordering these?
There was a problem hiding this comment.
They were ordered alphabetically by alias. The reason was human readability.
This PR is out-of-date. I did more work on this here fix_lwom, but test were failing because of imo unrelated reasons, and I did not add it to this PR.
I will rebase and try again. Hopefully, this PR is then in shape to be merged.
|
closing as stale. if you'd like to continue working, pls ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for PRs :
git diff upstream/master -u -- "*.py" | flake8 --diff