ERR: Better error message for missing matplotlib #20538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
force-pushed
the
mpl-import-msg
branch
from
dd1f1ac to
1159a75
Compare
Codecov Report
@@ Coverage Diff @@
## master #20538 +/- ##
==========================================
+ Coverage 91.81% 91.84% +0.02%
==========================================
Files 152 153 +1
Lines 49259 49265 +6
==========================================
+ Hits 45229 45245 +16
+ Misses 4030 4020 -10
Continue to review full report at Codecov.
|
pandas/util/_test_decorators.py
Outdated
| @@ -160,6 +160,8 @@ def decorated_func(func): | |||
|
|
|||
| skip_if_no_mpl = pytest.mark.skipif(_skip_if_no_mpl(), | |||
| reason="Missing matplotlib dependency") | |||
| skip_if_mpl = pytest.mark.skipif(not _skip_if_no_mpl(), | |||
| reason="matplotlib is pressent") | |||
There was a problem hiding this comment.
Do we have a test build that does not have matplotlib ?
jreback
reviewed
Mar 30, 2018
doc/source/whatsnew/v0.23.0.txt
Outdated
| @@ -958,6 +958,7 @@ Offsets | |||
|
|
|||
| Numeric | |||
| ^^^^^^^ | |||
| - Better error message when attempting to plot but matplotlib is not installed (:issue:`19810`). | |||
[ci skip]
|
https://travis-ci.org/pandas-dev/pandas/jobs/360014203 doesn't include matplotlib, and should have run this. |
gfyoung
reviewed
Mar 30, 2018
| @@ -17,6 +17,14 @@ | |||
| from pandas.tests.plotting.common import TestPlotBase, _check_plot_works | |||
|
|
|||
|
|
|||
| @td.skip_if_mpl | |||
| def test_import_error_message(): | |||
There was a problem hiding this comment.
Let's reference the issue number here.
gfyoung
reviewed
Mar 30, 2018
pandas/plotting/_core.py
Outdated
| @@ -97,6 +98,9 @@ def __init__(self, data, kind=None, by=None, subplots=False, sharex=None, | |||
| secondary_y=False, colormap=None, | |||
| table=False, layout=None, **kwds): | |||
|
|
|||
| if not _HAS_MPL: | |||
| raise ImportError("matplotlib is required for plotting.") | |||
There was a problem hiding this comment.
Can we just write a separate function for this check? You use this same code 4 times.
jorisvandenbossche
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19810