-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Extension whatsenw #20533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Extension whatsenw #20533
Conversation
* /tmp/doc/source/api.rst:2551: WARNING: toctree contains reference to nonexisting document 'generated/pandas.Timestamp.offset' * /home/travis/build/pandas-dev/pandas/pandas/core/series.py:docstring of pandas.Series.asobject:6: WARNING: Inline literal start-string without end-string. * /tmp/doc/source/io.rst:2265: WARNING: Unknown target name: "level". * /tmp/doc/source/overview.rst:123: WARNING: Include file '/tmp/LICENSE' not found or reading it failed �# Please enter the commit message for your changes. Lines starting
Whoops, looks like I branched off the wrong branch. Oh well, fixing some other warnings too I guess :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some minor comments
doc/source/whatsnew/v0.23.0.txt
Outdated
@@ -299,6 +299,61 @@ Supplying a ``CategoricalDtype`` will make the categories in each column consist | |||
df['A'].dtype | |||
df['B'].dtype | |||
|
|||
Extension Types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a more descriptive title like "Extending pandas with custom data types" ?
doc/source/whatsnew/v0.23.0.txt
Outdated
|
||
.. code-block:: ipython | ||
|
||
In [1]: import pandas as pd; from cyberpandas import IPArray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two lines?
doc/source/whatsnew/v0.23.0.txt
Outdated
...: | ||
|
||
``IPArray`` isn't a normal 1-D NumPy array, but because it's a pandas | ||
ExtensionArray, it can be stored properly inside pandas' containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quote ExtensionArray ?
Codecov Report
@@ Coverage Diff @@
## master #20533 +/- ##
==========================================
+ Coverage 91.81% 91.84% +0.02%
==========================================
Files 152 152
Lines 49259 49259
==========================================
+ Hits 45229 45241 +12
+ Misses 4030 4018 -12
Continue to review full report at Codecov.
|
DOC: various warnings.
Closes #20532