Skip to content

DOC: Extension whatsenw #20533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2018

Conversation

TomAugspurger
Copy link
Contributor

Closes #20532

* /tmp/doc/source/api.rst:2551: WARNING: toctree contains reference to
  nonexisting document 'generated/pandas.Timestamp.offset'
* /home/travis/build/pandas-dev/pandas/pandas/core/series.py:docstring of
  pandas.Series.asobject:6: WARNING: Inline literal start-string without
  end-string.
* /tmp/doc/source/io.rst:2265: WARNING: Unknown target name: "level".
* /tmp/doc/source/overview.rst:123: WARNING: Include file '/tmp/LICENSE' not
  found or reading it failed

�# Please enter the commit message for your changes. Lines starting
@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Mar 29, 2018
@TomAugspurger
Copy link
Contributor Author

Whoops, looks like I branched off the wrong branch. Oh well, fixing some other warnings too I guess :)

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor comments

@@ -299,6 +299,61 @@ Supplying a ``CategoricalDtype`` will make the categories in each column consist
df['A'].dtype
df['B'].dtype

Extension Types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more descriptive title like "Extending pandas with custom data types" ?


.. code-block:: ipython

In [1]: import pandas as pd; from cyberpandas import IPArray
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two lines?

...:

``IPArray`` isn't a normal 1-D NumPy array, but because it's a pandas
ExtensionArray, it can be stored properly inside pandas' containers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quote ExtensionArray ?

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #20533 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20533      +/-   ##
==========================================
+ Coverage   91.81%   91.84%   +0.02%     
==========================================
  Files         152      152              
  Lines       49259    49259              
==========================================
+ Hits        45229    45241      +12     
+ Misses       4030     4018      -12
Flag Coverage Δ
#multiple 90.23% <ø> (+0.02%) ⬆️
#single 41.89% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/series.py 93.85% <ø> (ø) ⬆️
pandas/plotting/_converter.py 66.81% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bc32b...e74d0f6. Read the comment docs.

@TomAugspurger TomAugspurger merged commit c4b4a81 into pandas-dev:master Mar 29, 2018
@TomAugspurger TomAugspurger deleted the extension-whatsenw branch March 29, 2018 20:10
kornilova203 pushed a commit to kornilova203/pandas that referenced this pull request Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants