-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Additional DOC and BUG fix related to merging with mix of columns and… #20475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20475 +/- ##
===========================================
+ Coverage 42.51% 92.25% +49.74%
===========================================
Files 161 161
Lines 51691 51692 +1
===========================================
+ Hits 21975 47690 +25715
+ Misses 29716 4002 -25714
Continue to review full report at Codecov.
|
pandas/tests/test_join.py
Outdated
|
||
|
||
def test_join_multi_to_multi(): | ||
leftindex = MultiIndex.from_product([list('abc'), list('xy'), [1, 2]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add this issue number here
ideally can you use the join_type fixture here (to run this for all join types)
you showed 3 examples in the OP, can you replicate them here |
@jreback I made the changes you asked for and it's all green |
@Dr-Irv this got a bit lost, can you rebase and update |
Hello @Dr-Irv! Thanks for updating the PR.
|
@jreback merged with latest, and now all green. I now added a line in whatsnew. |
@Dr-Irv sorry this wasn't merged before, can you do one more rebase please? |
@datapythonista now all green |
Sorry @Dr-Irv, another rebase needed. |
@datapythonista I've done the merge, but the failure is because there is something wrong on Azure. Up to you to decide how to proceed. |
@datapythonista Current merge is now all green. |
lgtm. @Dr-Irv just pushed a commit to fix whitespace. ping on green. |
thanks @Dr-Irv |
Checklist for other PRs (remove this part if you are doing a PR for the pandas documentation sprint):
git diff upstream/master -u -- "*.py" | flake8 --diff
This PR adds some documentation about how
MultiLevel
index levels are dropped when doing a merge that includes levels and columns. It also fixes a small bug related tojoin
.