-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Improving the docstring of Series.str.upper and related #20462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20462 +/- ##
==========================================
+ Coverage 91.82% 91.85% +0.02%
==========================================
Files 152 152
Lines 49248 49231 -17
==========================================
- Hits 45222 45220 -2
+ Misses 4026 4011 -15
Continue to review full report at Codecov.
|
pandas/core/strings.py
Outdated
Examples | ||
-------- | ||
>>> s = pd.Series(['lower', 'CAPITALS', 'this is a sentence', 'SwApCaSe']) | ||
>>> s.str.lower() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you show the original s
, (simply with a line >>> s
and its output). And then leave a blank line between it and the lower
method, so the lower doesn't get grouped with the constructor and the original, but in a separate block as the rest?
Besides that, lgtm.
pandas/core/strings.py
Outdated
|
||
See Also | ||
-------- | ||
Series.str.lower : Converts all characters to lower case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"lower case" -> "lowercase" ?
Or at least we should be consistent with what is substituted in the summary line (currently this is "lowercase")
Hello @Hamishpk! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on March 24, 2018 at 12:57 Hours UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[ci skip]
Fixed the doctest. thanks @Hamishpk |
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>
git diff upstream/master -u -- "*.py" | flake8 --diff
python doc/make.py --single <your-function-or-method>
Please include the output of the validation script below between the "```" ticks:
If the validation script still gives errors, but you think there is a good reason
to deviate in this case (and there are certainly such cases), please state this
explicitly.
Checklist for other PRs (remove this part if you are doing a PR for the pandas documentation sprint):
git diff upstream/master -u -- "*.py" | flake8 --diff