Skip to content

API: Preserve int columns in to_dict('index') #20444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2018
Merged

API: Preserve int columns in to_dict('index') #20444

merged 2 commits into from
Mar 25, 2018

Conversation

reidy-p
Copy link
Contributor

@reidy-p reidy-p commented Mar 21, 2018 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Mar 21, 2018 •
edited
Loading

Hello @reidy-p! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on March 22, 2018 at 19:31 Hours UTC

@reidy-p reidy-p force-pushed the to_dict_index_dtypes branch from f7d0ce2 to 8c57576 Compare March 21, 2018 23:00
@reidy-p reidy-p force-pushed the to_dict_index_dtypes branch from 8c57576 to 0eb250a Compare March 22, 2018 19:30
@codecov
Copy link

codecov bot commented Mar 22, 2018 •
edited
Loading

Codecov Report

Merging #20444 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20444   +/-   ##
=======================================
  Coverage    91.8%    91.8%           
=======================================
  Files         152      152           
  Lines       49223    49223           
=======================================
  Hits        45191    45191           
  Misses       4032     4032
Flag Coverage Δ
#multiple 90.19% <100%> (ø) ⬆️
#single 41.84% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 97.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02477da...16e1a08. Read the comment docs.

@reidy-p reidy-p force-pushed the to_dict_index_dtypes branch from 0eb250a to 16e1a08 Compare March 22, 2018 19:31
@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions API Design labels Mar 22, 2018
@jreback jreback added this to the 0.23.0 milestone Mar 22, 2018
@jreback
Copy link
Contributor

jreback commented Mar 22, 2018

lgtm. just want to make sure windows passes. ping on green.

@reidy-p
Copy link
Contributor Author

reidy-p commented Mar 22, 2018

@jreback it's green now. Thanks!

@jreback jreback merged commit b26f0f7 into pandas-dev:master Mar 25, 2018
@jreback
Copy link
Contributor

jreback commented Mar 25, 2018

thanks @reidy-p keep em coming!

@reidy-p reidy-p deleted the to_dict_index_dtypes branch March 25, 2018 16:09
javadnoorb pushed a commit to javadnoorb/pandas that referenced this pull request Mar 29, 2018
@reidy-p @javadnoorb
API: Preserve int columns in to_dict('index') (pandas-dev#20444)
c1cbd96
dworvos pushed a commit to dworvos/pandas that referenced this pull request Apr 2, 2018
@reidy-p
API: Preserve int columns in to_dict('index') (pandas-dev#20444)
d8c9cdd
kornilova203 pushed a commit to kornilova203/pandas that referenced this pull request Apr 23, 2018
@reidy-p @kornilova203
API: Preserve int columns in to_dict('index') (pandas-dev#20444)
02142d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Design Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

COMPAT: df.to_dict('index') is not preserving dtypes
3 participants
@reidy-p @pep8speaks @jreback