-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: update the Series.between docstring #20443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update the Series.between docstring #20443
Conversation
Hello @mrw34! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on March 24, 2018 at 07:57 Hours UTC |
f09c3c9
to
673a28e
Compare
Codecov Report
@@ Coverage Diff @@
## master #20443 +/- ##
==========================================
+ Coverage 91.82% 91.85% +0.02%
==========================================
Files 152 152
Lines 49248 49231 -17
==========================================
- Hits 45222 45220 -2
+ Misses 4026 4011 -15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, added couple of comments.
pandas/core/series.py
Outdated
See Also | ||
-------- | ||
DataFrame.query : Query the columns of a frame with a boolean | ||
expression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't find DataFrame.query
so related. But if we list it, I'd explain it a bit better than it can be used to perform comparisons, so users understand why it's related.
The ones that I do find related are Series.gt
and Series.lt
.
The See Also
section should be placed before the examples, not after.
pandas/core/series.py
Outdated
|
||
Examples | ||
-------- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this blank line.
pandas/core/series.py
Outdated
Right boundary | ||
Right boundary. | ||
inclusive : bool, default True | ||
Include boundaries. | ||
|
||
Returns | ||
------- | ||
is_between : Series |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can leave just Series
, or Series of bool
to be more explicit. The returned name is_between
is not needed.
@datapythonista Thanks Marc! Hopefully looking better now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[ci skip]
Thanks @mrw34 |
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>
git diff upstream/master -u -- "*.py" | flake8 --diff
python doc/make.py --single <your-function-or-method>
Please include the output of the validation script below between the "```" ticks: