parameterize tests in scalar/timedelta #20428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggli
changed the title
Codecov Report
@@ Coverage Diff @@
## master #20428 +/- ##
==========================================
- Coverage 91.8% 91.77% -0.03%
==========================================
Files 152 152
Lines 49215 49215
==========================================
- Hits 45181 45169 -12
- Misses 4034 4046 +12
Continue to review full report at Codecov.
|
WillAyd
reviewed
Mar 21, 2018
| @@ -195,28 +195,22 @@ def test_iso_constructor_raises(fmt): | |||
| Timedelta(fmt) | |||
|
|
|||
|
|
|||
| def test_td_constructor_on_nanoseconds(): | |||
| @pytest.mark.parametrize('constructed_td, conversion', | |||
There was a problem hiding this comment.
Just stylistically if you put the left bracket to start the list of parameters on the first line it could make this more readable (reduces the indentation required for every subsequent line)
There was a problem hiding this comment.
very good point. thanks!
jreback
added
Testing
|
thans @minggli happyily will take any parameterization tests! would take even w/o an issue |
javadnoorb
pushed a commit
to javadnoorb/pandas
that referenced
this pull request
Mar 29, 2018
dworvos
pushed a commit
to dworvos/pandas
that referenced
this pull request
Apr 2, 2018
kornilova203
pushed a commit
to kornilova203/pandas
that referenced
this pull request
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff