Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC: update pandas.core.groupby.DataFrameGroupBy.resample docstring. #20374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update pandas.core.groupby.DataFrameGroupBy.resample docstring. #20374
Changes from 7 commits
59355d6
deea3c7
2fcabf7
fdce932
4b55b5f
e7905b2
a0c5329
4880d3b
084ac39
73b480b
f375ceb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is "loffset" right? I don't know this section of the code all that well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert myself, I guess the type should be
DateOffset, tseries.offsets, timedelta, or str
?For what I can see, valid keywords should be
how
,fill_method
,limit
,kind
andon
(inget_resampler_for_grouping
),closed
,label
,how
,axis
,fill_method
,limit
,loffset
,kind
,convention
,base
(inTimeGrouper
), andkey
,level
,freq
,axis
,sort
(inGrouper
).What I'd do is to add the ones from
get_resampler_for_grouping
as explicit arguments, and then document that**kwargs
will be passed toTimeGrouper
.@jreback is it ok to change the signature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
level
,axis
,freq
,key
,sort
are all part of the grouper and not args to.resample()
or any aggregation function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pandres can you replace the description by something like:
We can improve that later in a separate PR, but I think we can merge all the rest of the changes for now.
Thanks!