DOC: make deprecation warning more visible with red box

[Imanflow]

• [x ] closes Add CSS formating for deprecated parameters / methods #20349
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[jorisvandenbossche]

How it currently looks:

So I think we need to add some more css to have it look better (border spacing). As comparison, the see also box:

[jorisvandenbossche]

Apparently I did something very similar for sklearn a while ago, so you can see there how I did it then: scikit-learn/scikit-learn#8914

[codecov]

Codecov Report

Merging #20357 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20357      +/-   ##
==========================================
+ Coverage   91.77%    91.8%   +0.02%     
==========================================
  Files         152      152              
  Lines       49205    49216      +11     
==========================================
+ Hits        45159    45182      +23     
+ Misses       4046     4034      -12

Flag	Coverage Δ
#multiple	90.19% <ø> (+0.02%)	⬆️
#single	41.84% <ø> (-0.01%)	⬇️

Impacted Files	Coverage Δ
pandas/core/window.py	96.26% <0%> (-0.01%)	⬇️
pandas/core/indexes/category.py	97.3% <0%> (ø)	⬆️
pandas/core/panel.py	97.29% <0%> (ø)	⬆️
pandas/core/series.py	93.84% <0%> (ø)	⬆️
pandas/core/base.py	96.78% <0%> (ø)	⬆️
pandas/core/arrays/categorical.py	96.21% <0%> (ø)	⬆️
pandas/core/generic.py	95.85% <0%> (ø)	⬆️
pandas/core/frame.py	97.18% <0%> (ø)	⬆️
pandas/core/indexes/datetimelike.py	96.72% <0%> (ø)	⬆️
pandas/plotting/_core.py	82.27% <0%> (ø)	⬆️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7273ea0...13188ad. Read the comment docs.

[jreback]

lgtm. @jorisvandenbossche ?

[jorisvandenbossche]

Don't merge yet. We should fix the styling.

@Imanflow you can take a look at the PR in sklearn I mentioned above how it was done there.

[Imanflow]

For a reason I can't undersand, further changes in https://github.com/pandas-dev/pandas/blob/master/doc/source/themes/nature_with_gtoc/static/nature.css_tdoesn't get reflected when i do

# in pandas/doc
python make.py --single=pandas.DataFrame.from_csv

any clue?

[arminv]

I'm not sure why you can't see your changes, but based on how @jorisvandenbossche fixed this issue before and #20349, you need:

div.admonition p.admonition-title + p, div.deprecated p {
    display: inline;
}

, div.deprecated p is missing in your code.

You also need:

div.deprecated {
    background-color: #ffe4e4;
    border: 1px solid #f66;
    margin-bottom: 10px;
    margin-top: 10px;
    padding: 7px;
    border-radius: 4px;
    -moz-border-radius: 4px;
}

I think the last two properties here (border-radius: 4px; and -moz-border-radius: 4px;) are not necessary as we want the box to have sharp edges and be consistent with 'See also' box etc,.

So you are missing these:

    margin-bottom: 10px;
    margin-top: 10px;
    padding: 7px;

This is how it should look:

[Imanflow]

Done, thanks for your patience.

PD: The problem with not seeing the changes was that on terminal I was in a different branch than in Pycharm.

[jorisvandenbossche]

Looks good!

[jorisvandenbossche]

@Imanflow @arminv Thanks!